diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-24 06:24:27 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-09-24 21:45:18 +0200 |
| commit | b8f37a4aa053c68836deca1ddeb509ce6f5ec0ae (patch) | |
| tree | 9766fb5e93bb448dabfc75b453be2384e7293906 | |
| parent | drivers/s390/net: removes unnecessary semicolon (diff) | |
| download | linux-b8f37a4aa053c68836deca1ddeb509ce6f5ec0ae.tar.xz linux-b8f37a4aa053c68836deca1ddeb509ce6f5ec0ae.zip | |
ctcm: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/s390/net/ctcm_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c index 5227e5734a9d..98ea9cc6f1aa 100644 --- a/drivers/s390/net/ctcm_main.c +++ b/drivers/s390/net/ctcm_main.c @@ -1454,7 +1454,7 @@ static int add_channel(struct ccw_device *cdev, enum ctcm_channel_types type, ch_fsm_len, GFP_KERNEL); } if (ch->fsm == NULL) - goto free_return; + goto nomem_return; fsm_newstate(ch->fsm, CTC_STATE_IDLE); |