diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2018-07-01 22:56:54 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2018-07-02 15:12:55 +0200 |
| commit | 1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd (patch) | |
| tree | f95d2185a3ae33b5d2a4abcf97a1b0a3e04fc642 | |
| parent | configfs: use kvasprintf() instead of open-coding it (diff) | |
| download | linux-1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd.tar.xz linux-1823342a1f2b47a4e6f5667f67cd28ab6bc4d6cd.zip | |
configfs: replace strncpy with memcpy
gcc 8.1.0 complains:
fs/configfs/symlink.c:67:3: warning:
'strncpy' output truncated before terminating nul copying as many
bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | fs/configfs/symlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c index 78ffc2699993..a5c54af861f7 100644 --- a/fs/configfs/symlink.c +++ b/fs/configfs/symlink.c @@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length) /* back up enough to print this bus id with '/' */ length -= cur; - strncpy(buffer + length,config_item_name(p),cur); + memcpy(buffer + length, config_item_name(p), cur); *(buffer + --length) = '/'; } } |