diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-02-05 10:48:28 +0100 |
|---|---|---|
| committer | Enric Balletbo i Serra <enric.balletbo@collabora.com> | 2020-02-11 10:32:50 +0100 |
| commit | 8673e944b50ec6e5afd4f599cf12b2798b629f3d (patch) | |
| tree | bb8de5a2db0a59a4ea1813e38044ba7eda208562 | |
| parent | Merge branch 'chrome-platform-5.6-fixes' into for-next (diff) | |
| download | linux-8673e944b50ec6e5afd4f599cf12b2798b629f3d.tar.xz linux-8673e944b50ec6e5afd4f599cf12b2798b629f3d.zip | |
platform/chrome: wilco_ec: Platform data shouldn't include kernel.h
Replace with appropriate types.h.
Also there is no need to include device.h, but mutex.h.
For the pointers to unknown structures use forward declarations.
In the *.c files we need to include all headers that provide APIs
being used in the module.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
| -rw-r--r-- | drivers/platform/chrome/wilco_ec/properties.c | 3 | ||||
| -rw-r--r-- | drivers/platform/chrome/wilco_ec/sysfs.c | 4 | ||||
| -rw-r--r-- | include/linux/platform_data/wilco-ec.h | 8 |
3 files changed, 13 insertions, 2 deletions
diff --git a/drivers/platform/chrome/wilco_ec/properties.c b/drivers/platform/chrome/wilco_ec/properties.c index 62f27610dd33..c2bf4c95c5d2 100644 --- a/drivers/platform/chrome/wilco_ec/properties.c +++ b/drivers/platform/chrome/wilco_ec/properties.c @@ -3,8 +3,11 @@ * Copyright 2019 Google LLC */ +#include <linux/errno.h> +#include <linux/export.h> #include <linux/platform_data/wilco-ec.h> #include <linux/string.h> +#include <linux/types.h> #include <asm/unaligned.h> /* Operation code; what the EC should do with the property */ diff --git a/drivers/platform/chrome/wilco_ec/sysfs.c b/drivers/platform/chrome/wilco_ec/sysfs.c index f0d174b6bb21..3c587b4054a5 100644 --- a/drivers/platform/chrome/wilco_ec/sysfs.c +++ b/drivers/platform/chrome/wilco_ec/sysfs.c @@ -8,8 +8,12 @@ * See Documentation/ABI/testing/sysfs-platform-wilco-ec for more information. */ +#include <linux/device.h> +#include <linux/kernel.h> #include <linux/platform_data/wilco-ec.h> +#include <linux/string.h> #include <linux/sysfs.h> +#include <linux/types.h> #define CMD_KB_CMOS 0x7C #define SUB_CMD_KB_CMOS_AUTO_ON 0x03 diff --git a/include/linux/platform_data/wilco-ec.h b/include/linux/platform_data/wilco-ec.h index afede15a95bf..25f46a939637 100644 --- a/include/linux/platform_data/wilco-ec.h +++ b/include/linux/platform_data/wilco-ec.h @@ -8,8 +8,8 @@ #ifndef WILCO_EC_H #define WILCO_EC_H -#include <linux/device.h> -#include <linux/kernel.h> +#include <linux/mutex.h> +#include <linux/types.h> /* Message flags for using the mailbox() interface */ #define WILCO_EC_FLAG_NO_RESPONSE BIT(0) /* EC does not respond */ @@ -17,6 +17,10 @@ /* Normal commands have a maximum 32 bytes of data */ #define EC_MAILBOX_DATA_SIZE 32 +struct device; +struct resource; +struct platform_device; + /** * struct wilco_ec_device - Wilco Embedded Controller handle. * @dev: Device handle. |