summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-08-11 03:01:13 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2010-08-11 17:59:00 +0200
commit95cc7baa7f19e191b4790d144b7cbe47369cfe32 (patch)
tree90197ae42d5b9ba0213e13684e64a04650735e34
parentNCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma() (diff)
downloadlinux-95cc7baa7f19e191b4790d144b7cbe47369cfe32.tar.xz
linux-95cc7baa7f19e191b4790d144b7cbe47369cfe32.zip
drivers/scsi: remove unnecessary NULL test
At the point where cmnd is initialized, it is tested for NULL, so it doesn't have to be tested again here. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // <smpl> @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/scsi/initio.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index a7714160fbc3..108797761b95 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -2817,7 +2817,6 @@ static void i91uSCBPost(u8 * host_mem, u8 * cblk_mem)
}
cmnd->result = cblk->tastat | (cblk->hastat << 16);
- WARN_ON(cmnd == NULL);
i91u_unmap_scb(host->pci_dev, cmnd);
cmnd->scsi_done(cmnd); /* Notify system DONE */
initio_release_scb(host, cblk); /* Release SCB for current channel */