diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2022-02-03 17:29:21 +0100 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2022-02-10 06:07:24 +0100 |
| commit | b97cca3ba9098522e5a1c3388764ead42640c1a5 (patch) | |
| tree | 231beccc5ac2a13adf75ed5811742640457e677f | |
| parent | xfs: ensure log flush at the end of a synchronous fallocate call (diff) | |
| download | linux-b97cca3ba9098522e5a1c3388764ead42640c1a5.tar.xz linux-b97cca3ba9098522e5a1c3388764ead42640c1a5.zip | |
xfs: only bother with sync_filesystem during readonly remount
In commit 02b9984d6408, we pushed a sync_filesystem() call from the VFS
into xfs_fs_remount. The only time that we ever need to push dirty file
data or metadata to disk for a remount is if we're remounting the
filesystem read only, so this really could be moved to xfs_remount_ro.
Once we've moved the call site, actually check the return value from
sync_filesystem.
Fixes: 02b9984d6408 ("fs: push sync_filesystem() down to the file system's remount_fs()")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
| -rw-r--r-- | fs/xfs/xfs_super.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index e8f37bdc8354..7c2f1338c6e8 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1749,6 +1749,11 @@ xfs_remount_ro( }; int error; + /* Flush all the dirty data to disk. */ + error = sync_filesystem(mp->m_super); + if (error) + return error; + /* * Cancel background eofb scanning so it cannot race with the final * log force+buftarg wait and deadlock the remount. @@ -1827,8 +1832,6 @@ xfs_fs_reconfigure( if (error) return error; - sync_filesystem(mp->m_super); - /* inode32 -> inode64 */ if (xfs_has_small_inums(mp) && !xfs_has_small_inums(new_mp)) { mp->m_features &= ~XFS_FEAT_SMALL_INUMS; |