summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGang He <ghe@suse.com>2020-08-07 08:17:56 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2020-08-07 20:33:21 +0200
commit504ec37dfdfbf9c65166c51f7b12126d2a9b18dc (patch)
tree5b71b21010320912f58251e86919bf986fc25b30
parentntfs: fix ntfs_test_inode and ntfs_init_locked_inode function type (diff)
downloadlinux-504ec37dfdfbf9c65166c51f7b12126d2a9b18dc.tar.xz
linux-504ec37dfdfbf9c65166c51f7b12126d2a9b18dc.zip
ocfs2: fix remounting needed after setfacl command
When use setfacl command to change a file's acl, the user cannot get the latest acl information from the file via getfacl command, until remounting the file system. e.g. setfacl -m u:ivan:rw /ocfs2/ivan getfacl /ocfs2/ivan getfacl: Removing leading '/' from absolute path names file: ocfs2/ivan owner: root group: root user::rw- group::r-- mask::r-- other::r-- The latest acl record("u:ivan:rw") cannot be returned via getfacl command until remounting. Signed-off-by: Gang He <ghe@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Changwei Ge <gechangwei@live.cn> Cc: Jun Piao <piaojun@huawei.com> Link: http://lkml.kernel.org/r/20200717023751.9922-1-ghe@suse.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/ocfs2/acl.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index bb981ec76456..7b07f5df3a29 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -256,6 +256,8 @@ static int ocfs2_set_acl(handle_t *handle,
ret = ocfs2_xattr_set(inode, name_index, "", value, size, 0);
kfree(value);
+ if (!ret)
+ set_cached_acl(inode, type, acl);
return ret;
}