diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2020-02-15 00:26:19 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-02-17 04:22:47 +0100 |
| commit | d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6 (patch) | |
| tree | aead72c559e29e12f803cc5f42c310cbf62ba8b6 | |
| parent | Merge branch 'wireguard-fixes' (diff) | |
| download | linux-d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6.tar.xz linux-d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6.zip | |
net: dsa: b53: Ensure the default VID is untagged
We need to ensure that the default VID is untagged otherwise the switch
will be sending tagged frames and the results can be problematic. This
is especially true with b53 switches that use VID 0 as their default
VLAN since VID 0 has a special meaning.
Fixes: fea83353177a ("net: dsa: b53: Fix default VLAN ID")
Fixes: 061f6a505ac3 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/dsa/b53/b53_common.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 449a22172e07..1a69286daa8d 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1366,6 +1366,9 @@ void b53_vlan_add(struct dsa_switch *ds, int port, b53_get_vlan_entry(dev, vid, vl); + if (vid == 0 && vid == b53_default_pvid(dev)) + untagged = true; + vl->members |= BIT(port); if (untagged && !dsa_is_cpu_port(ds, port)) vl->untag |= BIT(port); |