diff options
| author | qiuguorui1 <qiuguorui1@huawei.com> | 2021-02-18 13:59:00 +0100 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2021-02-19 18:57:40 +0100 |
| commit | 656d1d58d8e0958d372db86c24f0b2ea36f50888 (patch) | |
| tree | bb5eb10bb29bf51c58215bab4557073248cb5606 | |
| parent | arm64: spectre: Prevent lockdep splat on v4 mitigation enable path (diff) | |
| download | linux-656d1d58d8e0958d372db86c24f0b2ea36f50888.tar.xz linux-656d1d58d8e0958d372db86c24f0b2ea36f50888.zip | |
arm64: kexec_file: fix memory leakage in create_dtb() when fdt_open_into() fails
in function create_dtb(), if fdt_open_into() fails, we need to vfree
buf before return.
Fixes: 52b2a8af7436 ("arm64: kexec_file: load initrd and device-tree")
Cc: stable@vger.kernel.org # v5.0
Signed-off-by: qiuguorui1 <qiuguorui1@huawei.com>
Link: https://lore.kernel.org/r/20210218125900.6810-1-qiuguorui1@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
| -rw-r--r-- | arch/arm64/kernel/machine_kexec_file.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c index 03210f644790..0cde47a63beb 100644 --- a/arch/arm64/kernel/machine_kexec_file.c +++ b/arch/arm64/kernel/machine_kexec_file.c @@ -182,8 +182,10 @@ static int create_dtb(struct kimage *image, /* duplicate a device tree blob */ ret = fdt_open_into(initial_boot_params, buf, buf_size); - if (ret) + if (ret) { + vfree(buf); return -EINVAL; + } ret = setup_dtb(image, initrd_load_addr, initrd_len, cmdline, buf); |