diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2018-11-08 15:06:21 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-11-09 02:22:24 +0100 |
| commit | 9168f5ae3837dd98cb201d16f813c6f1d96670ca (patch) | |
| tree | ec2a46e592cf07a25c93ce3e1e84df25af117893 | |
| parent | s390/qeth: remove two IPA command helpers (diff) | |
| download | linux-9168f5ae3837dd98cb201d16f813c6f1d96670ca.tar.xz linux-9168f5ae3837dd98cb201d16f813c6f1d96670ca.zip | |
s390/qeth: remove unused fallback in Layer3's MAC code
If the CREATE ADDR sent by qeth_l3_iqd_read_initial_mac() fails, its
callback sets a random MAC address on the net_device. The error then
propagates back, and qeth_l3_setup_netdev() bails out without
registering the net_device.
Any subsequent call to qeth_l3_setup_netdev() will then attempt a fresh
CREATE ADDR which either 1) also fails, or 2) sets a proper MAC address
on the net_device. Consequently, the net_device will never be registered
with a random MAC and we can drop the fallback code.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/s390/net/qeth_l3_main.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 89d5e6fb21ac..674ff3344ff3 100644 --- a/drivers/s390/net/qeth_l3_main.c +++ b/drivers/s390/net/qeth_l3_main.c @@ -949,9 +949,6 @@ static int qeth_l3_iqd_read_initial_mac_cb(struct qeth_card *card, if (cmd->hdr.return_code == 0) ether_addr_copy(card->dev->dev_addr, cmd->data.create_destroy_addr.unique_id); - else - eth_random_addr(card->dev->dev_addr); - return 0; } |