diff options
| author | Mario Limonciello <mario.limonciello@amd.com> | 2021-07-07 16:16:47 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-07-14 15:39:47 +0200 |
| commit | a973c983375c37301645d4fea056b1f4bff77bf7 (patch) | |
| tree | c9b84ea3d285b7e11762d7a865247986423a1779 | |
| parent | platform/x86: amd-pmc: Add new acpi id for future PMC controllers (diff) | |
| download | linux-a973c983375c37301645d4fea056b1f4bff77bf7.tar.xz linux-a973c983375c37301645d4fea056b1f4bff77bf7.zip | |
platform/x86: amd-pmc: Use return code on suspend
Right now the driver will still return success even if the OS_HINT
command failed to send to the SMU. In the rare event of a failure,
the suspend should really be aborted here so that relevant logs
can may be captured.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20210707141647.8871-1-mario.limonciello@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| -rw-r--r-- | drivers/platform/x86/amd-pmc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index d2f9a62e1166..680f94c7e075 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -353,7 +353,7 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev) if (rc) dev_err(pdev->dev, "suspend failed\n"); - return 0; + return rc; } static int __maybe_unused amd_pmc_resume(struct device *dev) |