diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-12-03 09:39:48 +0100 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-12-10 22:37:33 +0100 |
| commit | ad8566d3555c4731e6b48823b92d3929b0394c14 (patch) | |
| tree | 7e3024a46ed4e2dbb6b13b23ccc2684535f91117 | |
| parent | mtd: rawnand: gpmi: Use of_device_get_match_data() (diff) | |
| download | linux-ad8566d3555c4731e6b48823b92d3929b0394c14.tar.xz linux-ad8566d3555c4731e6b48823b92d3929b0394c14.zip | |
mtd: rawnand: meson: Fix a resource leak in init
Call clk_disable_unprepare(nfc->phase_rx) if the clk_set_rate() function
fails to avoid a resource leak.
Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/X8ikVCnUsfTpffFB@mwanda
| -rw-r--r-- | drivers/mtd/nand/raw/meson_nand.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index a76afea6ea77..817bddccb775 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -1044,9 +1044,12 @@ static int meson_nfc_clk_init(struct meson_nfc *nfc) ret = clk_set_rate(nfc->device_clk, 24000000); if (ret) - goto err_phase_rx; + goto err_disable_rx; return 0; + +err_disable_rx: + clk_disable_unprepare(nfc->phase_rx); err_phase_rx: clk_disable_unprepare(nfc->phase_tx); err_phase_tx: |