diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-06-17 21:53:26 +0200 |
|---|---|---|
| committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2020-12-05 09:31:37 +0100 |
| commit | f15480e947d45959f0bcfba7318d369eebe47a59 (patch) | |
| tree | 0e591b5990fe56b72548433711d1d0e24b77610d | |
| parent | Merge tag 'for-5.10/dm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/gi... (diff) | |
| download | linux-f15480e947d45959f0bcfba7318d369eebe47a59.tar.xz linux-f15480e947d45959f0bcfba7318d369eebe47a59.zip | |
pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error
'status' is known to be 0 at this point. It must be set to a meaningful
value in order to return an error code if one of the 'of_get_property()'
call fails.
Return -EINVAL in such a case.
Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
| -rw-r--r-- | drivers/pcmcia/electra_cf.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index 35158cfd9c1a..40a5cffe24a4 100644 --- a/drivers/pcmcia/electra_cf.c +++ b/drivers/pcmcia/electra_cf.c @@ -229,6 +229,8 @@ static int electra_cf_probe(struct platform_device *ofdev) cf->socket.pci_irq = cf->irq; + status = -EINVAL; + prop = of_get_property(np, "card-detect-gpio", NULL); if (!prop) goto fail1; |