diff options
| author | Björn Ardö <bjorn.ardo@axis.com> | 2019-09-05 16:50:26 +0200 |
|---|---|---|
| committer | Wolfram Sang <wsa@the-dreams.de> | 2019-09-05 22:26:04 +0200 |
| commit | fe050f99072d6b5175c35427a6f72846790441ec (patch) | |
| tree | 0a90880a508cdac4dc14e318d7be660983410c13 | |
| parent | i2c: exynos5: Remove IRQF_ONESHOT (diff) | |
| download | linux-fe050f99072d6b5175c35427a6f72846790441ec.tar.xz linux-fe050f99072d6b5175c35427a6f72846790441ec.zip | |
i2c: slave-eeprom: Add comment about address handling
The behaviour of the EEPROM in the case where we only send an 8bit
address to a 16bit address EEPROM is not defined. Added comment about
that the slave-eeprom might behave differently from how an actual device
does (only one model measured).
Reported-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Björn Ardö <bjorn.ardo@axis.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
| -rw-r--r-- | drivers/i2c/i2c-slave-eeprom.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c index 773afaabfb61..92ff9991bae8 100644 --- a/drivers/i2c/i2c-slave-eeprom.c +++ b/drivers/i2c/i2c-slave-eeprom.c @@ -11,6 +11,12 @@ * pointer, yet implementation is deferred until the need actually arises. */ +/* + * FIXME: What to do if only 8 bits of a 16 bit address are sent? + * The ST-M24C64 sends only 0xff then. Needs verification with other + * EEPROMs, though. We currently use the 8 bit as a valid address. + */ + #include <linux/bitfield.h> #include <linux/i2c.h> #include <linux/init.h> |