diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-03-14 12:06:06 +0100 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2011-03-23 17:36:43 +0100 |
| commit | 12a18bdc27f81ba9d0a08a2462a49d339fff8b2d (patch) | |
| tree | 1716220b96063beee30742468afd5922c71f5998 | |
| parent | [SCSI] target: Avoid mem leak and needless work in transport_generic_get_mem (diff) | |
| download | linux-12a18bdc27f81ba9d0a08a2462a49d339fff8b2d.tar.xz linux-12a18bdc27f81ba9d0a08a2462a49d339fff8b2d.zip | |
[SCSI] target: Fix bogus return in transport_add_device_to_core_hba failure path
This patch removes a bogus conditional+return check within the failure path
of transport_add_device_to_core_hba(). This breakage was introduced during
the v4 conversion to remove struct se_cmd passthrough ops for INQUIRY /
READ_CAPCITY during struct se_device creation and registration process.
Reported-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
| -rw-r--r-- | drivers/target/target_core_transport.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 67d4286cf244..bf6aa8a9f1d8 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -1620,7 +1620,7 @@ struct se_device *transport_add_device_to_core_hba( const char *inquiry_prod, const char *inquiry_rev) { - int ret = 0, force_pt; + int force_pt; struct se_device *dev; dev = kzalloc(sizeof(struct se_device), GFP_KERNEL); @@ -1737,9 +1737,8 @@ struct se_device *transport_add_device_to_core_hba( } scsi_dump_inquiry(dev); + return dev; out: - if (!ret) - return dev; kthread_stop(dev->process_thread); spin_lock(&hba->device_lock); |