summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBreno Leitao <leitao@linux.vnet.ibm.com>2010-07-01 05:00:18 +0200
committerDavid S. Miller <davem@davemloft.net>2010-07-03 06:59:06 +0200
commit7ae80abdba0644e12ac17da567a2db1efc1bf8a8 (patch)
treef7e71b7a6c0383e982e02c0b74adb16f36263006
parentqlge: Replacing add_timer() to mod_timer() (diff)
downloadlinux-7ae80abdba0644e12ac17da567a2db1efc1bf8a8.tar.xz
linux-7ae80abdba0644e12ac17da567a2db1efc1bf8a8.zip
qlge: fix a eeh handler to not add a pending timer
On some ocasions the function qlge_io_resume() tries to add a pending timer, which causes the system to hit the BUG() on add_timer() function. This patch removes the timer during the EEH recovery. Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/qlge/qlge_main.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
index 509dadcd1c5a..d10bcefc0e45 100644
--- a/drivers/net/qlge/qlge_main.c
+++ b/drivers/net/qlge/qlge_main.c
@@ -4712,6 +4712,8 @@ static void ql_eeh_close(struct net_device *ndev)
netif_stop_queue(ndev);
}
+ /* Disabling the timer */
+ del_timer_sync(&qdev->timer);
if (test_bit(QL_ADAPTER_UP, &qdev->flags))
cancel_delayed_work_sync(&qdev->asic_reset_work);
cancel_delayed_work_sync(&qdev->mpi_reset_work);