diff options
author | Jan Kara <jack@suse.cz> | 2012-02-10 10:50:07 +0100 |
---|---|---|
committer | Joel Becker <jlbec@evilplan.org> | 2012-07-04 08:27:17 +0200 |
commit | a4564ead763a9264edbec6d4e72aa273f05eb39c (patch) | |
tree | 946afa2ff636bcb7837fb50587f54077aacc0d3c | |
parent | ocfs2: for SEEK_DATA/SEEK_HOLE, return internal error unchanged if ocfs2_get_... (diff) | |
download | linux-a4564ead763a9264edbec6d4e72aa273f05eb39c.tar.xz linux-a4564ead763a9264edbec6d4e72aa273f05eb39c.zip |
ocfs2: Fix bogus error message from ocfs2_global_read_info
'status' variable in ocfs2_global_read_info() is always != 0 when leaving the
function because it happens to contain number of read bytes. Thus we always log
error message although everything is OK. Since all error cases properly call
mlog_errno() before jumping to out_err, there's no reason to call mlog_errno()
on exit at all. This is a fallout of c1e8d35e (conversion of mlog_exit()
calls).
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Joel Becker <jlbec@evilplan.org>
-rw-r--r-- | fs/ocfs2/quota_global.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 92fcd575775a..0a86e302655f 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -399,8 +399,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type) msecs_to_jiffies(oinfo->dqi_syncms)); out_err: - if (status) - mlog_errno(status); return status; out_unlock: ocfs2_unlock_global_qf(oinfo, 0); |