diff options
| author | Pi-Hsun Shih <pihsun@chromium.org> | 2019-05-20 08:51:19 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2019-05-31 09:32:06 +0200 |
| commit | a9fb94a99bb515d8720ba8440ce3aba84aec80f8 (patch) | |
| tree | d272383bd25c4efd32c2d3449aeb76cabf52314b | |
| parent | Linux 5.2-rc1 (diff) | |
| download | linux-a9fb94a99bb515d8720ba8440ce3aba84aec80f8.tar.xz linux-a9fb94a99bb515d8720ba8440ce3aba84aec80f8.zip | |
pstore: Set tfm to NULL on free_buf_for_compression
Set tfm to NULL on free_buf_for_compression() after crypto_free_comp().
This avoid a use-after-free when allocate_buf_for_compression()
and free_buf_for_compression() are called twice. Although
free_buf_for_compression() freed the tfm, allocate_buf_for_compression()
won't reinitialize the tfm since the tfm pointer is not NULL.
Fixes: 95047b0519c1 ("pstore: Refactor compression initialization")
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
| -rw-r--r-- | fs/pstore/platform.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 75887a269b64..8355a46638d0 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -347,8 +347,10 @@ static void allocate_buf_for_compression(void) static void free_buf_for_compression(void) { - if (IS_ENABLED(CONFIG_PSTORE_COMPRESS) && tfm) + if (IS_ENABLED(CONFIG_PSTORE_COMPRESS) && tfm) { crypto_free_comp(tfm); + tfm = NULL; + } kfree(big_oops_buf); big_oops_buf = NULL; big_oops_buf_sz = 0; |