summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Kelly <mkelly@xevo.com>2017-12-05 20:15:47 +0100
committerMarc Kleine-Budde <mkl@pengutronix.de>2017-12-08 10:45:11 +0100
commitbd352e1adfe0d02d3ea7c8e3fb19183dc317e679 (patch)
tree0d1c5d339c5b3b9fe9732677a1de8d2d9341cfe9
parentcan: mcba_usb: cancel urb on -EPROTO (diff)
downloadlinux-bd352e1adfe0d02d3ea7c8e3fb19183dc317e679.tar.xz
linux-bd352e1adfe0d02d3ea7c8e3fb19183dc317e679.zip
can: ems_usb: cancel urb on -EPIPE and -EPROTO
In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly <mkelly@xevo.com> Cc: linux-stable <stable@vger.kernel.org> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
-rw-r--r--drivers/net/can/usb/ems_usb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index b3d02759c226..b00358297424 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -288,6 +288,8 @@ static void ems_usb_read_interrupt_callback(struct urb *urb)
case -ECONNRESET: /* unlink */
case -ENOENT:
+ case -EPIPE:
+ case -EPROTO:
case -ESHUTDOWN:
return;