diff options
| author | Eric Dumazet <edumazet@google.com> | 2016-11-16 15:12:42 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-11-16 23:06:51 +0100 |
| commit | ea339343d64a14594d882ccb52e8619d42defe5e (patch) | |
| tree | f87ec272642d36dceac0715e235f6b7d2e0527a3 | |
| parent | virtio-net: add a missing synchronize_net() (diff) | |
| download | linux-ea339343d64a14594d882ccb52e8619d42defe5e.tar.xz linux-ea339343d64a14594d882ccb52e8619d42defe5e.zip | |
be2net: do not call napi_hash_del()
Calling napi_hash_del() before netif_napi_del() is dangerous
if a synchronize_rcu() is not enforced before NAPI struct freeing.
Lets leave this detail to core networking stack and feel
more comfortable.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Sathya Perla <sathya.perla@broadcom.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index cece8a08edca..93aa2939142a 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -2813,7 +2813,6 @@ static void be_evt_queues_destroy(struct be_adapter *adapter) if (eqo->q.created) { be_eq_clean(eqo); be_cmd_q_destroy(adapter, &eqo->q, QTYPE_EQ); - napi_hash_del(&eqo->napi); netif_napi_del(&eqo->napi); free_cpumask_var(eqo->affinity_mask); } |