diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-21 15:20:12 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-25 02:24:31 +0100 |
| commit | f910b6cba27af4c5e1b0de1225a268448c2e82be (patch) | |
| tree | 3d48cc9c85e7c822db8a9891a63063e75ff1c70c | |
| parent | USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev" (diff) | |
| download | linux-f910b6cba27af4c5e1b0de1225a268448c2e82be.tar.xz linux-f910b6cba27af4c5e1b0de1225a268448c2e82be.zip | |
USB: PCI-quirks: Deletion of unnecessary checks before the function call "pci_dev_put"
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/host/pci-quirks.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 2f3acebb577a..dd483c13565b 100644 --- a/drivers/usb/host/pci-quirks.c +++ b/drivers/usb/host/pci-quirks.c @@ -233,10 +233,8 @@ commit: spin_unlock_irqrestore(&amd_lock, flags); - if (info.nb_dev) - pci_dev_put(info.nb_dev); - if (info.smbus_dev) - pci_dev_put(info.smbus_dev); + pci_dev_put(info.nb_dev); + pci_dev_put(info.smbus_dev); } else { /* no race - commit the result */ @@ -447,10 +445,8 @@ void usb_amd_dev_put(void) spin_unlock_irqrestore(&amd_lock, flags); - if (nb) - pci_dev_put(nb); - if (smbus) - pci_dev_put(smbus); + pci_dev_put(nb); + pci_dev_put(smbus); } EXPORT_SYMBOL_GPL(usb_amd_dev_put); |