summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2012-05-29 13:38:32 +0200
committerFelipe Balbi <balbi@ti.com>2012-06-03 22:11:34 +0200
commit23673d7d26d81bd17cde3ed74c57b3f39585325f (patch)
treee269bf56ca6bdd6a1e40ddba6ee42f70798e93b5
parentusb: gadget: omap_udc: remove possiblity of NULL pointer de-reference (diff)
downloadlinux-23673d7d26d81bd17cde3ed74c57b3f39585325f.tar.xz
linux-23673d7d26d81bd17cde3ed74c57b3f39585325f.zip
usb: gadget: omap_udc: kfree(NULL) is safe
we don't need to check for _req because kfree(NULL) is safe. Also, if someone actually passes a NULL pointer to be freed by usb_ep_free_request(), he deserves any issue he faces. Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/gadget/omap_udc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index f13bcdc75676..50e8490867ed 100644
--- a/drivers/usb/gadget/omap_udc.c
+++ b/drivers/usb/gadget/omap_udc.c
@@ -282,8 +282,7 @@ omap_free_request(struct usb_ep *ep, struct usb_request *_req)
{
struct omap_req *req = container_of(_req, struct omap_req, req);
- if (_req)
- kfree(req);
+ kfree(req);
}
/*-------------------------------------------------------------------------*/