diff options
| author | Eugen Hristev <eugen.hristev@microchip.com> | 2019-04-15 16:13:56 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-05-21 13:20:28 +0200 |
| commit | 5490ba5645f27829e5c7f7c6fd3a9249cc14198e (patch) | |
| tree | ed5f6cb75aa7faae1223c54c14d3a6da7d346f51 | |
| parent | media: atmel: atmel-isc: add support for DO_WHITE_BALANCE (diff) | |
| download | linux-5490ba5645f27829e5c7f7c6fd3a9249cc14198e.tar.xz linux-5490ba5645f27829e5c7f7c6fd3a9249cc14198e.zip | |
media: atmel: atmel-isc: make try_fmt error less verbose
In case the sensor refuses to set the format, avoid printing the error
message that no compatible format was found.
This means that the try_fmt will be less verbose.
The error will be printed only if really a format cannot be found.
Some application try all possible formats in a row (gstreamer e.g.)
which will flood the console with error messages until a working one is found.
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| -rw-r--r-- | drivers/media/platform/atmel/atmel-isc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c index 777e27f325f2..da3b441e7961 100644 --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -1487,7 +1487,7 @@ static int isc_try_fmt(struct isc_device *isc, struct v4l2_format *f, ret = v4l2_subdev_call(isc->current_subdev->sd, pad, set_fmt, &pad_cfg, &format); if (ret < 0) - goto isc_try_fmt_err; + goto isc_try_fmt_subdev_err; v4l2_fill_pix_format(pixfmt, &format.format); @@ -1502,6 +1502,7 @@ static int isc_try_fmt(struct isc_device *isc, struct v4l2_format *f, isc_try_fmt_err: v4l2_err(&isc->v4l2_dev, "Could not find any possible format for a working pipeline\n"); +isc_try_fmt_subdev_err: memset(&isc->try_config, 0, sizeof(isc->try_config)); return ret; |