diff options
| author | Vladimir Zapolskiy <vz@mleia.com> | 2016-03-10 00:22:19 +0100 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2016-08-31 01:41:43 +0200 |
| commit | 91e630d9ae6de6f740ef7c8176736eb55366833e (patch) | |
| tree | 5041057fb7bb3d50805dd0de8c29d0126b337675 | |
| parent | dm log writes: fix bug with too large bios (diff) | |
| download | linux-91e630d9ae6de6f740ef7c8176736eb55366833e.tar.xz linux-91e630d9ae6de6f740ef7c8176736eb55366833e.zip | |
dm log writes: fix check of kthread_run() return value
The kthread_run() function returns either a valid task_struct or
ERR_PTR() value, check for NULL is invalid. This change fixes potential
for oops, e.g. in OOM situation.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
| -rw-r--r-- | drivers/md/dm-log-writes.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index ba24f4f37efc..49e4d8d4558f 100644 --- a/drivers/md/dm-log-writes.c +++ b/drivers/md/dm-log-writes.c @@ -459,9 +459,9 @@ static int log_writes_ctr(struct dm_target *ti, unsigned int argc, char **argv) goto bad; } - ret = -EINVAL; lc->log_kthread = kthread_run(log_writes_kthread, lc, "log-write"); - if (!lc->log_kthread) { + if (IS_ERR(lc->log_kthread)) { + ret = PTR_ERR(lc->log_kthread); ti->error = "Couldn't alloc kthread"; dm_put_device(ti, lc->dev); dm_put_device(ti, lc->logdev); |