diff options
| author | Michael Ellerman <michael@ellerman.id.au> | 2008-07-24 06:28:57 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-24 19:47:25 +0200 |
| commit | f3db6639fee577f6ed92c0a1fc881e748c47ec48 (patch) | |
| tree | dc6a84609a8838ebbf9d094f4ef67adb32eb10a9 | |
| parent | checkpatch: types: some types may also be identifiers (diff) | |
| download | linux-f3db6639fee577f6ed92c0a1fc881e748c47ec48.tar.xz linux-f3db6639fee577f6ed92c0a1fc881e748c47ec48.zip | |
checkpatch: add a checkpatch warning for new uses of __initcall().
[apw@shadowen.org: generalise pattern and add tests]
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 5420db6502fc..cf70f123f574 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2108,6 +2108,10 @@ sub process { if ($line =~ /\bsimple_(strto.*?)\s*\(/) { WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr); } +# check for __initcall(), use device_initcall() explicitly please + if ($line =~ /^.\s*__initcall\s*\(/) { + WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); + } # use of NR_CPUS is usually wrong # ignore definitions of NR_CPUS and usage to define arrays as likely right |