diff options
| author | Mark Brown <broonie@linaro.org> | 2014-08-15 13:51:28 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-08-15 13:51:28 +0200 |
| commit | 0a81cbefba91cb1a77170f8fbf082114590c3e14 (patch) | |
| tree | e3b85d99c34d370673252b22a4800afb0d0bdb07 | |
| parent | Merge tag 'asoc-v3.17' into asoc-linus (diff) | |
| parent | ASoC: dapm: Fix uninitialized variable in snd_soc_dapm_get_enum_double() (diff) | |
| download | linux-0a81cbefba91cb1a77170f8fbf082114590c3e14.tar.xz linux-0a81cbefba91cb1a77170f8fbf082114590c3e14.zip | |
Merge remote-tracking branch 'asoc/fix/dapm' into asoc-linus
| -rw-r--r-- | sound/soc/soc-dapm.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 8348352dc2c6..177bd8639ef9 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -2860,12 +2860,14 @@ int snd_soc_dapm_get_enum_double(struct snd_kcontrol *kcontrol, struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kcontrol); struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; unsigned int reg_val, val; - int ret = 0; - if (e->reg != SND_SOC_NOPM) - ret = soc_dapm_read(dapm, e->reg, ®_val); - else + if (e->reg != SND_SOC_NOPM) { + int ret = soc_dapm_read(dapm, e->reg, ®_val); + if (ret) + return ret; + } else { reg_val = dapm_kcontrol_get_value(kcontrol); + } val = (reg_val >> e->shift_l) & e->mask; ucontrol->value.enumerated.item[0] = snd_soc_enum_val_to_item(e, val); @@ -2875,7 +2877,7 @@ int snd_soc_dapm_get_enum_double(struct snd_kcontrol *kcontrol, ucontrol->value.enumerated.item[1] = val; } - return ret; + return 0; } EXPORT_SYMBOL_GPL(snd_soc_dapm_get_enum_double); |