summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenny Halevy <bhalevy@primarydata.com>2013-10-15 08:57:55 +0200
committerJ. Bruce Fields <bfields@redhat.com>2013-10-28 20:58:20 +0100
commit5d7dab83e3e55e81a88c406da71afde0ebaa6ad8 (patch)
tree34773e8b12f70aa456ccd025c2f2cb24d5ddedf1
parentnfsd: nfs4_free_stid (diff)
downloadlinux-5d7dab83e3e55e81a88c406da71afde0ebaa6ad8.tar.xz
linux-5d7dab83e3e55e81a88c406da71afde0ebaa6ad8.zip
nfsd: nfs4_open_delegation needs to remove_stid rather than unhash_stid
In the out_free: path, the newly allocated stid must be removed rather than unhashed so it can never be found. Signed-off-by: Benny Halevy <bhalevy@primarydata.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/nfs4state.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 9cb1b17014f5..3feb38e818ab 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3159,7 +3159,7 @@ nfs4_open_delegation(struct net *net, struct svc_fh *fh,
open->op_delegate_type = NFS4_OPEN_DELEGATE_READ;
return;
out_free:
- unhash_stid(&dp->dl_stid);
+ remove_stid(&dp->dl_stid);
nfs4_put_delegation(dp);
out_no_deleg:
open->op_delegate_type = NFS4_OPEN_DELEGATE_NONE;