summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChao Yu <yuchao0@huawei.com>2018-07-29 06:16:59 +0200
committerJaegeuk Kim <jaegeuk@kernel.org>2018-08-11 01:19:05 +0200
commit66110abc4c931f879d70e83e1281f891699364bf (patch)
tree430fb43344fd922e3a491402a704bb23a3916612
parentf2fs: fix to active page in lru list for read path (diff)
downloadlinux-66110abc4c931f879d70e83e1281f891699364bf.tar.xz
linux-66110abc4c931f879d70e83e1281f891699364bf.zip
f2fs: fix to clear PG_checked flag in set_page_dirty()
PG_checked flag will be set on data page during GC, later, we can recognize such page by the flag and migrate page to cold segment. But previously, we don't clear this flag when invalidating data page, after page redirtying, we will write it into wrong log. Let's clear PG_checked flag in set_page_dirty() to avoid this. Signed-off-by: Weichao Guo <guoweichao@huawei.com> Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r--fs/f2fs/data.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5d152de30449..b7986b2e5d1d 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2542,6 +2542,10 @@ static int f2fs_set_data_page_dirty(struct page *page)
if (!PageUptodate(page))
SetPageUptodate(page);
+ /* don't remain PG_checked flag which was set during GC */
+ if (is_cold_data(page))
+ clear_cold_data(page);
+
if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) {
if (!IS_ATOMIC_WRITTEN_PAGE(page)) {
f2fs_register_inmem_page(inode, page);