summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-08-06 14:51:10 +0200
committerJiri Kosina <jkosina@suse.cz>2010-08-06 14:51:10 +0200
commita106025015c8d24af6518aba3ac19c4dc9098b7c (patch)
treeca9b00e352edd8707c45cffbd514dd2a96418fd3
parentMerge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jiko... (diff)
downloadlinux-a106025015c8d24af6518aba3ac19c4dc9098b7c.tar.xz
linux-a106025015c8d24af6518aba3ac19c4dc9098b7c.zip
HID: picolcd: testing the wrong variable
"ref_cnt" is a point to the reference count and it's non-null. We really want to test the reference count itself. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-picolcd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
index 346f0e34987e..c0bdebac5672 100644
--- a/drivers/hid/hid-picolcd.c
+++ b/drivers/hid/hid-picolcd.c
@@ -547,7 +547,7 @@ static void picolcd_fb_destroy(struct fb_info *info)
ref_cnt--;
mutex_lock(&info->lock);
(*ref_cnt)--;
- may_release = !ref_cnt;
+ may_release = !*ref_cnt;
mutex_unlock(&info->lock);
if (may_release) {
framebuffer_release(info);