diff options
| author | Sanidhya Kashyap <sanidhya.gatech@gmail.com> | 2015-04-16 21:48:26 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-17 15:04:09 +0200 |
| commit | c8f33d0bec999a4f2b5c3f9380361b88ce6f6ab0 (patch) | |
| tree | 7f5ff253261b35a918b9223e21ac9cf5cdc3814c | |
| parent | fs/affs: use affs_test_opt() (diff) | |
| download | linux-c8f33d0bec999a4f2b5c3f9380361b88ce6f6ab0.tar.xz linux-c8f33d0bec999a4f2b5c3f9380361b88ce6f6ab0.zip | |
affs: kstrdup() memory handling
There is a possibility of kstrdup() failure upon memory pressure.
Therefore, returning ENOMEM even for new_opts.
[akpm@linux-foundation.org: cleanup]
Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
Cc: Taesoo kim <taesoo@gatech.edu>
Cc: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/affs/super.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/affs/super.c b/fs/affs/super.c index 6819d0426af5..3f89c9e05b40 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c @@ -521,10 +521,14 @@ affs_remount(struct super_block *sb, int *flags, char *data) int root_block; unsigned long mount_flags; int res = 0; - char *new_opts = kstrdup(data, GFP_KERNEL); + char *new_opts; char volume[32]; char *prefix = NULL; + new_opts = kstrdup(data, GFP_KERNEL); + if (!new_opts) + return -ENOMEM; + pr_debug("%s(flags=0x%x,opts=\"%s\")\n", __func__, *flags, data); sync_filesystem(sb); |