summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLee Nipper <lee.nipper@freescale.com>2008-07-17 09:58:08 +0200
committerHerbert Xu <herbert@gondor.apana.org.au>2008-07-17 09:58:08 +0200
commit4aaf087846f9a1f1ec272393f5cd78f713e24f37 (patch)
treeffe02b01565ff7785bb7dd43f5651cfc10eb672d
parentscsi_dh: Verify "dev" is a sdev before accessing it. (diff)
downloadlinux-4aaf087846f9a1f1ec272393f5cd78f713e24f37.tar.xz
linux-4aaf087846f9a1f1ec272393f5cd78f713e24f37.zip
crypto: talitos - Remove calls to of_node_put
Remove of_node_put calls since there is no corresponding of_node_get. This patch prevents an exception when talitos is loaded a 2nd time. This sequence: modprobe talitos; rmmod talitos; modprobe talitos causes this message: "WARNING: Bad of_node_put() on /soc8349@e0000000/crypto@30000". Signed-off-by: Lee Nipper <lee.nipper@freescale.com> Signed-off-by: Kim Phillips <kim.phillips@freescale.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/talitos.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index b11943dadefd..01e6595014ee 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1466,9 +1466,6 @@ static int talitos_probe(struct of_device *ofdev,
goto err_out;
}
- of_node_put(np);
- np = NULL;
-
priv->head_lock = kmalloc(sizeof(spinlock_t) * priv->num_channels,
GFP_KERNEL);
priv->tail_lock = kmalloc(sizeof(spinlock_t) * priv->num_channels,
@@ -1559,8 +1556,6 @@ static int talitos_probe(struct of_device *ofdev,
err_out:
talitos_remove(ofdev);
- if (np)
- of_node_put(np);
return err;
}