summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Hills <mark@pogo.org.uk>2012-05-11 19:31:55 +0200
committerTakashi Iwai <tiwai@suse.de>2012-05-11 21:27:36 +0200
commit7df4a691fb6645405c9d3dad8d27f8e5e3451e00 (patch)
tree670a39092dfb19b493611151a62537b6b3294b18
parentALSA: pcm - Optimize the call of snd_pcm_update_hw_ptr() in read/write loop (diff)
downloadlinux-7df4a691fb6645405c9d3dad8d27f8e5e3451e00.tar.xz
linux-7df4a691fb6645405c9d3dad8d27f8e5e3451e00.zip
ALSA: usb-audio: Fix comment
Explained by Takashi in <s5hfwbtmz0q.wl%tiwai@suse.de> > The reason is because get_min_max*() isn't called in the place you > created these controls, and get_min_max() would be called only for > integer volumes later even if uninitialized. A short cut for booleans. Signed-off-by: Mark Hills <mark@pogo.org.uk> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/usb/mixer_quirks.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index 12125ca7167f..41f4b6911920 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -79,16 +79,8 @@ static int snd_create_std_mono_ctl(struct usb_mixer_interface *mixer,
cval->control = control;
cval->cmask = cmask;
- /* FIXME: Do we need this?
- * The following values are for compatibility with
- * Ebox-44 mixer.
- * But the corresponding ebox-44 function says:
- * "Volume controls will override these values"
- *
- * These values don't have any effect at all for
- * M-Audio FTUs.
- * So I think, we can safely omit the range settings here.
- */
+ /* get_min_max() is called only for integer volumes later,
+ * so provide a short-cut for booleans */
cval->min = 0;
cval->max = 1;
cval->res = 0;