diff options
| author | Alex Shi <alex.shi@linaro.org> | 2017-01-12 14:27:02 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2017-01-30 10:56:00 +0100 |
| commit | 8e37e1a2a3295f5d99e6dbe99eca24eca7a034ef (patch) | |
| tree | 438adb2db9f79ec2752cc045b97414b1be87a505 | |
| parent | ACPI / idle: small formatting fixes (diff) | |
| download | linux-8e37e1a2a3295f5d99e6dbe99eca24eca7a034ef.tar.xz linux-8e37e1a2a3295f5d99e6dbe99eca24eca7a034ef.zip | |
cpuidle/menu: stop seeking deeper idle if current state is deep enough
Obsolete commit 71abbbf856a0 (cpuidle: extend cpuidle and menu governor
to handle dynamic states) wanted to introduce dynamic C-states, but that
idea was dropped long ago. The nonsense deeper C-state checking
remained, though.
Since both target_residency and exit_latency are longer for deeper
idle state, there's no need to waste CPU time on useless checks.
Signed-off-by: Alex Shi <alex.shi@linaro.org>
Acked-by: Rik van Riel <riel@redhat.com>
[ rjw: Subject & changelog ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/cpuidle/governors/menu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c index d9b5b9398a0f..07e36bb54006 100644 --- a/drivers/cpuidle/governors/menu.c +++ b/drivers/cpuidle/governors/menu.c @@ -357,9 +357,9 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) if (s->disabled || su->disable) continue; if (s->target_residency > data->predicted_us) - continue; + break; if (s->exit_latency > latency_req) - continue; + break; data->last_state_idx = i; } |