diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2012-12-31 18:37:11 +0100 |
|---|---|---|
| committer | Oleg Nesterov <oleg@redhat.com> | 2013-02-08 17:47:13 +0100 |
| commit | af4355e91f15812df8608925738c91be57c580dd (patch) | |
| tree | d50a8fb2a2240f00e8d72a804de237552d7f1b36 | |
| parent | uprobes: Do not allocate current->utask unnecessary (diff) | |
| download | linux-af4355e91f15812df8608925738c91be57c580dd.tar.xz linux-af4355e91f15812df8608925738c91be57c580dd.zip | |
uprobes: Kill the bogus IS_ERR_VALUE(xol_vaddr) check
utask->xol_vaddr is either zero or valid, remove the bogus
IS_ERR_VALUE() check in xol_free_insn_slot().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Anton Arapov <anton@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| -rw-r--r-- | kernel/events/uprobes.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 071edcb3e62d..f6c7062fb950 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1223,8 +1223,7 @@ static void xol_free_insn_slot(struct task_struct *tsk) return; slot_addr = tsk->utask->xol_vaddr; - - if (unlikely(!slot_addr || IS_ERR_VALUE(slot_addr))) + if (unlikely(!slot_addr)) return; area = tsk->mm->uprobes_state.xol_area; |