diff options
| author | Namjae Jeon <namjae.jeon@samsung.com> | 2013-04-19 18:27:21 +0200 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk.kim@samsung.com> | 2013-04-23 01:56:21 +0200 |
| commit | e66509f03e36ef4750bfab8f3a5cf632b313a39b (patch) | |
| tree | 846716d7314bf03fe3657eaedd765e00983ceca2 | |
| parent | f2fs: fix error return code in f2fs_fill_super() (diff) | |
| download | linux-e66509f03e36ef4750bfab8f3a5cf632b313a39b.tar.xz linux-e66509f03e36ef4750bfab8f3a5cf632b313a39b.zip | |
f2fs: make is_multimedia_file code align with its name
The code conditions put inside the function is_multimedia_file are
reverse to the name i.e, we need to negate the return to actually
check if the file is a multimedia file. So, change the code and usage
path to align both the name and comparision conditions.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
| -rw-r--r-- | fs/f2fs/namei.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 841f6b486bd6..1dbf11d2bc87 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -83,7 +83,7 @@ static int is_multimedia_file(const unsigned char *s, const char *sub) int ret; if (sublen > slen) - return 1; + return 0; ret = memcmp(s + slen - sublen, sub, sublen); if (ret) { /* compare upper case */ @@ -91,10 +91,10 @@ static int is_multimedia_file(const unsigned char *s, const char *sub) char upper_sub[8]; for (i = 0; i < sublen && i < sizeof(upper_sub); i++) upper_sub[i] = toupper(sub[i]); - return memcmp(s + slen - sublen, upper_sub, sublen); + return !memcmp(s + slen - sublen, upper_sub, sublen); } - return ret; + return !ret; } /* @@ -108,7 +108,7 @@ static inline void set_cold_files(struct f2fs_sb_info *sbi, struct inode *inode, int count = le32_to_cpu(sbi->raw_super->extension_count); for (i = 0; i < count; i++) { - if (!is_multimedia_file(name, extlist[i])) { + if (is_multimedia_file(name, extlist[i])) { set_cold_file(inode); break; } |