diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-06-04 12:23:21 +0200 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2010-06-08 01:33:35 +0200 |
| commit | e902a358c753b93245083201c02312a580cf13d4 (patch) | |
| tree | 4c9248bf285f366bd9b2e0508f69f0a408a9797c | |
| parent | drm/fb: use printk to print out the switching to text mode error. (diff) | |
| download | linux-e902a358c753b93245083201c02312a580cf13d4.tar.xz linux-e902a358c753b93245083201c02312a580cf13d4.zip | |
drm/drm_crtc: return -EFAULT on copy_to_user errors
copy_from_user() returns the number of bytes left to be copied but we
want to return a negative error code here. This is in the ioctl handler
so the error code get returned to userspace.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/drm_crtc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 994d23beeb1d..57cea01c4ffb 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -1840,8 +1840,10 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev, ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips)); - if (ret) + if (ret) { + ret = -EFAULT; goto out_err2; + } } if (fb->funcs->dirty) { |