diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-08-29 20:31:49 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-02-26 19:10:50 +0100 |
| commit | fb3ab105a5ef43b03d2788e9b124c7c69112682f (patch) | |
| tree | 7f2abc1370c9d899ac93d1f0f04377049e369f0c | |
| parent | V4L/DVB: cx18: Add missing serialization locks to cx18-dvb (diff) | |
| download | linux-fb3ab105a5ef43b03d2788e9b124c7c69112682f.tar.xz linux-fb3ab105a5ef43b03d2788e9b124c7c69112682f.zip | |
V4L/DVB: stv0900: dereference of state->internal in fe_stv0900_error stv0900_init_internal()
state->internal allocation may fail as well as the allocation of
stv0900_first_inode or new_node->next_inode in append_internal().
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/dvb/frontends/stv0900_core.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/media/dvb/frontends/stv0900_core.c b/drivers/media/dvb/frontends/stv0900_core.c index 74791d550dc7..e5791b2b913b 100644 --- a/drivers/media/dvb/frontends/stv0900_core.c +++ b/drivers/media/dvb/frontends/stv0900_core.c @@ -1384,7 +1384,14 @@ static enum fe_stv0900_error stv0900_init_internal(struct dvb_frontend *fe, } else { state->internal = kmalloc(sizeof(struct stv0900_internal), GFP_KERNEL); + if (state->internal == NULL) + return STV0900_INVALID_HANDLE; temp_int = append_internal(state->internal); + if (temp_int == NULL) { + kfree(state->internal); + state->internal = NULL; + return STV0900_INVALID_HANDLE; + } state->internal->dmds_used = 1; state->internal->i2c_adap = state->i2c_adap; state->internal->i2c_addr = state->config->demod_address; |