summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSergiy Kibrik <sakib@meta.ua>2015-05-16 15:55:03 +0200
committerFelipe Balbi <balbi@ti.com>2015-05-26 17:15:02 +0200
commit10f095801cda5cdf24839e2fe90c08cb85a28da6 (patch)
tree028f60f5f2f02b3551db20c545f9944ba31b87d4
parentusb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros (diff)
downloadlinux-10f095801cda5cdf24839e2fe90c08cb85a28da6.tar.xz
linux-10f095801cda5cdf24839e2fe90c08cb85a28da6.zip
usb: s3c2410_udc: correct reversed pullup logic
For some reason the code has always been disabling pullup when asked to do the opposite. According to surrounding code and gadget API this seems to be a mistake. This fix allows UDC to be detected by host controller on recent kernels. Signed-off-by: Sergiy Kibrik <sakib@meta.ua> Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/gadget/udc/s3c2410_udc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
index b808951491cc..99fd9a5667df 100644
--- a/drivers/usb/gadget/udc/s3c2410_udc.c
+++ b/drivers/usb/gadget/udc/s3c2410_udc.c
@@ -1487,7 +1487,7 @@ static int s3c2410_udc_pullup(struct usb_gadget *gadget, int is_on)
dprintk(DEBUG_NORMAL, "%s()\n", __func__);
- s3c2410_udc_set_pullup(udc, is_on ? 0 : 1);
+ s3c2410_udc_set_pullup(udc, is_on);
return 0;
}