summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Blanchard <anton@samba.org>2010-09-07 03:21:41 +0200
committerDavid S. Miller <davem@davemloft.net>2010-09-07 03:21:41 +0200
commitf89e49e79f839dbe79364ec6cd7e2274ad11b120 (patch)
tree45d75386c47d38f940770326ade59bc57a27c93c
parentibmveth: Add rx_copybreak (diff)
downloadlinux-f89e49e79f839dbe79364ec6cd7e2274ad11b120.tar.xz
linux-f89e49e79f839dbe79364ec6cd7e2274ad11b120.zip
ibmveth: Use lighter weight read memory barrier in ibmveth_poll
We want to order the read in ibmveth_rxq_pending_buffer and the read of ibmveth_rxq_buffer_valid which are both cacheable memory. smp_rmb() is good enough for this. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Santiago Leon <santil@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ibmveth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index c236c8af3367..aedcb1802182 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -1010,7 +1010,7 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
if (!ibmveth_rxq_pending_buffer(adapter))
break;
- rmb();
+ smp_rmb();
if (!ibmveth_rxq_buffer_valid(adapter)) {
wmb(); /* suggested by larson1 */
adapter->rx_invalid_buffer++;