summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Klocke <philipp97kl@gmail.com>2018-10-18 12:33:02 +0200
committerTakashi Iwai <tiwai@suse.de>2018-10-18 15:44:08 +0200
commiteb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27 (patch)
tree4cf2157f187d5485ee79f9bbd2c747feef56d273
parentALSA: doc: Brush up the old writing-an-alsa-driver (diff)
downloadlinux-eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27.tar.xz
linux-eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27.zip
ALSA: i2c/cs8427: Fix int to char conversion
Compiling with clang yields the following warning: sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int' to 'char' changes value from 160 to -96 [-Wconstant-conversion] data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF; ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ Because CS8427_REG_AUTOINC is defined as 128, it is too big for a char field. So change data from char to unsigned char, that it can hold the value. This patch does not change the generated code. Signed-off-by: Philipp Klocke <philipp97kl@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/i2c/cs8427.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
index 2647309bc675..8afa2f888466 100644
--- a/sound/i2c/cs8427.c
+++ b/sound/i2c/cs8427.c
@@ -118,7 +118,7 @@ static int snd_cs8427_send_corudata(struct snd_i2c_device *device,
struct cs8427 *chip = device->private_data;
char *hw_data = udata ?
chip->playback.hw_udata : chip->playback.hw_status;
- char data[32];
+ unsigned char data[32];
int err, idx;
if (!memcmp(hw_data, ndata, count))