diff options
| author | Ursula Braun <ubraun@linux.vnet.ibm.com> | 2017-04-10 14:57:57 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-12 05:01:14 +0200 |
| commit | 249633a443fd12485d6f352d6cbe41efc92db233 (patch) | |
| tree | 20c5bc6a978c79b705daf8f7ad6dfc327853f09c | |
| parent | net/smc: get rid of old comment (diff) | |
| download | linux-249633a443fd12485d6f352d6cbe41efc92db233.tar.xz linux-249633a443fd12485d6f352d6cbe41efc92db233.zip | |
net/smc: remove useless smc_ib_devices_list check
The global event handler is created only, if the ib_device has already
been used by at least one link group. It is guaranteed that there exists
the corresponding entry in the smc_ib_devices list. Get rid of this
superfluous check.
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/smc/smc_ib.c | 2 | ||||
| -rw-r--r-- | net/smc/smc_pnet.c | 2 | ||||
| -rw-r--r-- | net/smc/smc_pnet.h | 1 |
3 files changed, 1 insertions, 4 deletions
diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c index e6743c008ac5..b76257798ba5 100644 --- a/net/smc/smc_ib.c +++ b/net/smc/smc_ib.c @@ -179,8 +179,6 @@ static void smc_ib_global_event_handler(struct ib_event_handler *handler, u8 port_idx; smcibdev = container_of(handler, struct smc_ib_device, event_handler); - if (!smc_pnet_find_ib(smcibdev->ibdev->name)) - return; switch (ibevent->event) { case IB_EVENT_PORT_ERR: diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c index 9d3e7fb8348d..f1cff0159980 100644 --- a/net/smc/smc_pnet.c +++ b/net/smc/smc_pnet.c @@ -219,7 +219,7 @@ static bool smc_pnetid_valid(const char *pnet_name, char *pnetid) } /* Find an infiniband device by a given name. The device might not exist. */ -struct smc_ib_device *smc_pnet_find_ib(char *ib_name) +static struct smc_ib_device *smc_pnet_find_ib(char *ib_name) { struct smc_ib_device *ibdev; diff --git a/net/smc/smc_pnet.h b/net/smc/smc_pnet.h index 32ab3df928ca..c4f1bccd4358 100644 --- a/net/smc/smc_pnet.h +++ b/net/smc/smc_pnet.h @@ -16,7 +16,6 @@ struct smc_ib_device; int smc_pnet_init(void) __init; void smc_pnet_exit(void); int smc_pnet_remove_by_ibdev(struct smc_ib_device *ibdev); -struct smc_ib_device *smc_pnet_find_ib(char *ib_name); void smc_pnet_find_roce_resource(struct sock *sk, struct smc_ib_device **smcibdev, u8 *ibport); |