diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-08-06 01:00:31 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2017-08-06 01:00:31 +0200 |
| commit | 381cebfe72e17e495281c07c976797f5a397515a (patch) | |
| tree | ece9bc4bd3cde775c7582ca75192159d58412c54 | |
| parent | ext4: fix SEEK_HOLE/SEEK_DATA for blocksize < pagesize (diff) | |
| download | linux-381cebfe72e17e495281c07c976797f5a397515a.tar.xz linux-381cebfe72e17e495281c07c976797f5a397515a.zip | |
ext4: silence array overflow warning
I get a static checker warning:
fs/ext4/ext4.h:3091 ext4_set_de_type()
error: buffer overflow 'ext4_type_by_mode' 15 <= 15
It seems unlikely that we would hit this read overflow in real life, but
it's also simple enough to make the array 16 bytes instead of 15.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/ext4.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index dcbcd9d444d1..2d6d4c952492 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -3072,7 +3072,7 @@ extern int ext4_handle_dirty_dirent_node(handle_t *handle, struct inode *inode, struct buffer_head *bh); #define S_SHIFT 12 -static const unsigned char ext4_type_by_mode[S_IFMT >> S_SHIFT] = { +static const unsigned char ext4_type_by_mode[(S_IFMT >> S_SHIFT) + 1] = { [S_IFREG >> S_SHIFT] = EXT4_FT_REG_FILE, [S_IFDIR >> S_SHIFT] = EXT4_FT_DIR, [S_IFCHR >> S_SHIFT] = EXT4_FT_CHRDEV, |