diff options
| author | Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> | 2009-11-17 23:10:11 +0100 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2009-11-26 17:04:22 +0100 |
| commit | 4e46bf89972b9d98a9f282a9fed2359756a5e34e (patch) | |
| tree | 7e55e191d74412735f8e9cd96e50dd50f34b9a5e | |
| parent | [SCSI] fix async scan add/remove race resulting in an oops (diff) | |
| download | linux-4e46bf89972b9d98a9f282a9fed2359756a5e34e.tar.xz linux-4e46bf89972b9d98a9f282a9fed2359756a5e34e.zip | |
[SCSI] fix crash when disconnecting usb storage
__scsi_remove_device() in scsi_forget_host() is executed out of scan_mutex
and races with scsi_destroy_sdev() <- scsi_sysfs_add_devices() <-
scsi_finish_async_scan(). The result is use after free and/or double
free, oops.
The fix is simple, move scsi_forget_host() under scan_mutex.
scsi_forget_host() is just sequence of __scsi_remove_device(). All
another calls of __scsi_remove_device() are made under scan_mutex. So
that it is safe.
Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
| -rw-r--r-- | drivers/scsi/hosts.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 5fd2da494d08..c968cc31cd86 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -164,8 +164,8 @@ void scsi_remove_host(struct Scsi_Host *shost) return; } spin_unlock_irqrestore(shost->host_lock, flags); - mutex_unlock(&shost->scan_mutex); scsi_forget_host(shost); + mutex_unlock(&shost->scan_mutex); scsi_proc_host_rm(shost); spin_lock_irqsave(shost->host_lock, flags); |