summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Paris <eparis@redhat.com>2010-11-24 00:18:37 +0100
committerEric Paris <eparis@redhat.com>2010-12-07 22:14:22 +0100
commita2ae4cc9a16e211c8a128ba10d22a85431f093ab (patch)
tree9de9f2c95163bf53b44413de542f5be528ff302f
parentfanotify: on group destroy allow all waiters to bypass permission check (diff)
downloadlinux-a2ae4cc9a16e211c8a128ba10d22a85431f093ab.tar.xz
linux-a2ae4cc9a16e211c8a128ba10d22a85431f093ab.zip
inotify: stop kernel memory leak on file creation failure
If inotify_init is unable to allocate a new file for the new inotify group we leak the new group. This patch drops the reference on the group on file allocation failure. Reported-by: Vegard Nossum <vegard.nossum@gmail.com> cc: stable@kernel.org Signed-off-by: Eric Paris <eparis@redhat.com>
-rw-r--r--fs/notify/inotify/inotify_user.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
index 444c305a468c..4cd5d5d78f9f 100644
--- a/fs/notify/inotify/inotify_user.c
+++ b/fs/notify/inotify/inotify_user.c
@@ -752,6 +752,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags)
if (ret >= 0)
return ret;
+ fsnotify_put_group(group);
atomic_dec(&user->inotify_devs);
out_free_uid:
free_uid(user);