diff options
| author | Soren Brinkmann <soren.brinkmann@xilinx.com> | 2013-04-16 19:06:50 +0200 |
|---|---|---|
| committer | Mike Turquette <mturquette@linaro.org> | 2013-06-15 23:34:41 +0200 |
| commit | f3aab5d61400b794ec759b9345e93e7ba57eb369 (patch) | |
| tree | 2b2c865e022402c483e9d7ba62ae2af5f29cfdd7 | |
| parent | MAINTAINERS: make drivers/clk entry match subdirs (diff) | |
| download | linux-f3aab5d61400b794ec759b9345e93e7ba57eb369.tar.xz linux-f3aab5d61400b794ec759b9345e93e7ba57eb369.zip | |
clk: Always notify whole subtree when reparenting
A clock's notifier count only reflects notifiers which are registered
directly for that clock. A reparent operation though affects the whole
subtree because of a potential rate change.
When issuing the pre rate change notifications only the notifier count
for the clock to be changed is considered and notifiers for subclocks
may never be called. Resulting in clocks in the subtree which have
registered notifiers, may receive a POST_- or ABORT_RATE_CHANGE
notification, without a PRE_RATE_CHANGE_NOTIFICATION.
Therefore always traverse the whole subtree when issueing pre rate
change notifications during a reparent operation.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
| -rw-r--r-- | drivers/clk/clk.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 2e669a87fb15..edf3fe100542 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1493,8 +1493,7 @@ int clk_set_parent(struct clk *clk, struct clk *parent) } /* propagate PRE_RATE_CHANGE notifications */ - if (clk->notifier_count) - ret = __clk_speculate_rates(clk, p_rate); + ret = __clk_speculate_rates(clk, p_rate); /* abort if a driver objects */ if (ret & NOTIFY_STOP_MASK) |