summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohan Hovold <jhovold@gmail.com>2013-09-10 12:50:49 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-09-17 19:05:47 +0200
commitfc0919c68cb2f75bb1af759315f9d7e2a9443c28 (patch)
tree1c41e68d65d2e6cf9355edad0c675dbd34e2bc67
parentserial: tegra: fix tty-kref leak (diff)
downloadlinux-fc0919c68cb2f75bb1af759315f9d7e2a9443c28.tar.xz
linux-fc0919c68cb2f75bb1af759315f9d7e2a9443c28.zip
serial: pch_uart: fix tty-kref leak in rx-error path
Fix tty-kref leak introduced by commit 384e301e ("pch_uart: fix a deadlock when pch_uart as console") which never put its tty reference. Cc: stable@vger.kernel.org Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/pch_uart.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 52379e56a31e..f0161d6ccc5c 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -1098,6 +1098,8 @@ static void pch_uart_err_ir(struct eg20t_port *priv, unsigned int lsr)
if (tty == NULL) {
for (i = 0; error_msg[i] != NULL; i++)
dev_err(&priv->pdev->dev, error_msg[i]);
+ } else {
+ tty_kref_put(tty);
}
}