diff options
| author | Mintz, Yuval <Yuval.Mintz@cavium.com> | 2017-06-07 20:00:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-06-08 16:58:02 +0200 |
| commit | 0eed9cf58446b28b233388b7f224cbca268b6986 (patch) | |
| tree | ee130169c37ed56a1be14d4f76f5d677f92d655b | |
| parent | decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb (diff) | |
| download | linux-0eed9cf58446b28b233388b7f224cbca268b6986.tar.xz linux-0eed9cf58446b28b233388b7f224cbca268b6986.zip | |
net: Zero ifla_vf_info in rtnl_fill_vfinfo()
Some of the structure's fields are not initialized by the
rtnetlink. If driver doesn't set those in ndo_get_vf_config(),
they'd leak memory to user.
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
CC: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/rtnetlink.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 9e2c0a7cb325..5e61456f6bc7 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1124,6 +1124,8 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, struct ifla_vf_mac vf_mac; struct ifla_vf_info ivi; + memset(&ivi, 0, sizeof(ivi)); + /* Not all SR-IOV capable drivers support the * spoofcheck and "RSS query enable" query. Preset to * -1 so the user space tool can detect that the driver @@ -1132,7 +1134,6 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, ivi.spoofchk = -1; ivi.rss_query_en = -1; ivi.trusted = -1; - memset(ivi.mac, 0, sizeof(ivi.mac)); /* The default value for VF link state is "auto" * IFLA_VF_LINK_STATE_AUTO which equals zero */ |