summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVignesh Babu <vignesh.babu@wipro.com>2007-07-18 15:11:02 +0200
committerTheodore Ts'o <tytso@mit.edu>2007-07-18 15:11:02 +0200
commit1330593eb2d055bdd6ed935886cf2c13c896b288 (patch)
treee4e73798e07758eb029625fc04c82385ec6749ee
parentUse zero_user_page() in ext4 where possible (diff)
downloadlinux-1330593eb2d055bdd6ed935886cf2c13c896b288.tar.xz
linux-1330593eb2d055bdd6ed935886cf2c13c896b288.zip
ext4: Use is_power_of_2()
Replace (n & (n-1)) in the context of power of 2 checks with is_power_of_2() Signed-off-by: Vignesh Babu <vignesh.babu@wipro.com> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r--fs/ext4/super.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index b47259f6f39c..6dcbb28dc06d 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -36,6 +36,7 @@
#include <linux/namei.h>
#include <linux/quotaops.h>
#include <linux/seq_file.h>
+#include <linux/log2.h>
#include <asm/uaccess.h>
@@ -1644,7 +1645,7 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent)
sbi->s_inode_size = le16_to_cpu(es->s_inode_size);
sbi->s_first_ino = le32_to_cpu(es->s_first_ino);
if ((sbi->s_inode_size < EXT4_GOOD_OLD_INODE_SIZE) ||
- (sbi->s_inode_size & (sbi->s_inode_size - 1)) ||
+ (!is_power_of_2(sbi->s_inode_size)) ||
(sbi->s_inode_size > blocksize)) {
printk (KERN_ERR
"EXT4-fs: unsupported inode size: %d\n",