summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGary R Hook <gary.hook@amd.com>2017-06-19 19:31:17 +0200
committerHerbert Xu <herbert@gondor.apana.org.au>2017-06-22 10:54:09 +0200
commit30b4c54ccdebfc5a0210d9a4d77cc3671c9d1576 (patch)
tree7b4cc0c05baa47e39360dd72b15411f46001f35c
parentcrypto: cavium/nitrox - dma_mapping_error() returns bool (diff)
downloadlinux-30b4c54ccdebfc5a0210d9a4d77cc3671c9d1576.tar.xz
linux-30b4c54ccdebfc5a0210d9a4d77cc3671c9d1576.zip
crypto: ccp - Release locks before returning
krobot warning: make sure that all error return paths release locks. Signed-off-by: Gary R Hook <gary.hook@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/ccp/ccp-debugfs.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/crypto/ccp/ccp-debugfs.c b/drivers/crypto/ccp/ccp-debugfs.c
index 6d86693b117f..3cd6c83754e0 100644
--- a/drivers/crypto/ccp/ccp-debugfs.c
+++ b/drivers/crypto/ccp/ccp-debugfs.c
@@ -297,12 +297,11 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
return;
write_lock_irqsave(&ccp_debugfs_lock, flags);
- if (!ccp_debugfs_dir) {
+ if (!ccp_debugfs_dir)
ccp_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
- if (!ccp_debugfs_dir)
- return;
- }
write_unlock_irqrestore(&ccp_debugfs_lock, flags);
+ if (!ccp_debugfs_dir)
+ return;
ccp->debugfs_instance = debugfs_create_dir(ccp->name, ccp_debugfs_dir);
if (!ccp->debugfs_instance)