diff options
| author | Lothar Waßmann <LW@KARO-electronics.de> | 2014-08-20 08:38:36 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2014-08-20 14:23:00 +0200 |
| commit | 937222c4dda495277a8dfbc18bf7e54fe670105c (patch) | |
| tree | 41fd4cc338bd4dd3136237df05e7414146c50516 | |
| parent | Linux 3.17-rc1 (diff) | |
| download | linux-937222c4dda495277a8dfbc18bf7e54fe670105c.tar.xz linux-937222c4dda495277a8dfbc18bf7e54fe670105c.zip | |
pwm-backlight: Fix bogus request for GPIO#0 when instantiated from DT
commit 257462dbf3ed ("pwm-backlight: switch to gpiod interface")
introduced a regression leading to acquiring a bogus GPIO-0 when
configured from DT without an 'enable-gpios' property.
The driver will happily accept the 0 initialized 'enable_gpio' member
of the struct platform_pwm_backlight_data as valid gpio number, and
request this GPIO as enable pin. In case of multiple driver instances,
the second will fail to register with the error message:
pwm-backlight backlight1.23: failed to request GPIO#0: -16
Fix this by setting enable_gpio in the pdata struct to -EINVAL.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/video/backlight/pwm_bl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index d7a3d13e72ec..b85983e97f0a 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -173,6 +173,7 @@ static int pwm_backlight_parse_dt(struct device *dev, data->max_brightness--; } + data->enable_gpio = -EINVAL; return 0; } |