diff options
| author | Christian Engelmayer <cengelma@gmx.at> | 2014-05-17 23:52:03 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-05-19 03:14:43 +0200 |
| commit | da26a625bfa8d12b789f12a107a2e389c236c362 (patch) | |
| tree | 5b981da204f04375137c885a58efa9518918267d | |
| parent | ipv4: minor spelling fix (diff) | |
| download | linux-da26a625bfa8d12b789f12a107a2e389c236c362.tar.xz linux-da26a625bfa8d12b789f12a107a2e389c236c362.zip | |
net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()
Function mlx4_en_set_channels() stops running ports before performing the
requested action. In that case local variable 'port_up' is set so that the
port is restarted at the end of the function, however, in case the port was
not stopped, variable 'port_up' is left uninitialized and the behaviour is
undetermined. Detected by Coverity - CID 751497.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Acked-By: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c index a72d99fd7a2d..7ba3df3cb312 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c @@ -1121,7 +1121,7 @@ static int mlx4_en_set_channels(struct net_device *dev, { struct mlx4_en_priv *priv = netdev_priv(dev); struct mlx4_en_dev *mdev = priv->mdev; - int port_up; + int port_up = 0; int err = 0; if (channel->other_count || channel->combined_count || |